imply-cheddar commented on code in PR #14542:
URL: https://github.com/apache/druid/pull/14542#discussion_r1261932195
##########
extensions-contrib/tdigestsketch/src/test/java/org/apache/druid/query/aggregation/tdigestsketch/sql/TDigestSketchSqlAggregatorTest.java:
##########
@@ -444,7 +443,11 @@ public void testEmptyTimeseriesResults()
Druids.newTimeseriesQueryBuilder()
.dataSource(CalciteTests.DATASOURCE1)
.intervals(new
MultipleIntervalSegmentSpec(ImmutableList.of(Filtration.eternity())))
- .filters(bound("dim2", "0", "0", false, false, null,
StringComparators.NUMERIC))
+ .filters(
+ NullHandling.replaceWithDefault()
+ ? numericSelector("dim2", "0", null)
+ : equality("dim2", 0L, ColumnType.LONG)
+ )
Review Comment:
You could have 2 different static methods, one for when we expect it to be
running against a numerical column and one for when we do not.
That said, I'm not making this comment because I care deeply that it be done
differently. I'm just saying it because it would work. What you have makes
sense and you can also keep it like it is now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
