clintropolis commented on code in PR #14542:
URL: https://github.com/apache/druid/pull/14542#discussion_r1260808126
##########
processing/src/main/java/org/apache/druid/query/filter/DruidPredicateFactory.java:
##########
@@ -33,6 +38,11 @@ public interface DruidPredicateFactory
DruidDoublePredicate makeDoublePredicate();
+ default Predicate<Object[]> makeArrayPredicate(@Nullable
TypeSignature<ValueType> inputType)
+ {
+ throw new UOE("Predicate does not support ARRAY types");
Review Comment:
oops, I meant to do a bit more with this. I intended to throw this exception
here, and have `ColumnProcessors.makeProcessor` or maybe the filter value
matcher makers that call that catch this exception so that they can throw a
`USER` persona exception that is actually useful. The reason is that the
predicate factory itself doesn't have anything that would help the user make
sense of the message, like the column(s) that were being filtered, the type of
filter, etc, we can at best here only know the predicate class type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
