clintropolis commented on code in PR #14542:
URL: https://github.com/apache/druid/pull/14542#discussion_r1260799891


##########
processing/src/main/java/org/apache/druid/math/expr/ExprEval.java:
##########
@@ -142,6 +142,26 @@ public static void serialize(ByteBuffer buffer, int 
position, ExpressionType typ
     }
   }
 
+  public static byte[] toBytes(ExpressionType expressionType, 
NullableTypeStrategy<Object> strategy, Object o)
+  {
+    // convert the array to byte[] form so that we take a hash of the whole 
array

Review Comment:
   oops, i moved this code here from where it was in hll sketch or.. bloom 
filter or .. somewhere else originally where the comment made more sense



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to