clintropolis commented on code in PR #14542:
URL: https://github.com/apache/druid/pull/14542#discussion_r1264036158
##########
processing/src/main/java/org/apache/druid/segment/filter/ColumnComparisonFilter.java:
##########
@@ -233,6 +235,26 @@ public Supplier<String[]>
makeLongProcessor(BaseLongColumnValueSelector selector
};
}
+ @Override
+ public Supplier<String[]> makeArrayProcessor(
+ BaseObjectColumnValueSelector<?> selector,
+ ColumnCapabilities columnCapabilities
+ )
+ {
+ return () -> {
+ final Object o = selector.getObject();
+ if (o instanceof Object[]) {
+ final Object[] arr = (Object[]) o;
+ final String[] s = new String[arr.length];
+ for (int i = 0; i < arr.length; i++) {
+ s[i] = Evals.asString(arr[i]);
+ }
+ return s;
+ }
Review Comment:
seems not documented, i'm not entirely sure why it does this like this I was
just matching the other cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
