clintropolis commented on code in PR #14542:
URL: https://github.com/apache/druid/pull/14542#discussion_r1264052898
##########
processing/src/main/java/org/apache/druid/segment/ColumnProcessorFactory.java:
##########
@@ -76,6 +77,8 @@ public interface ColumnProcessorFactory<T>
*/
T makeLongProcessor(BaseLongColumnValueSelector selector);
+ T makeArrayProcessor(BaseObjectColumnValueSelector<?> selector,
ColumnCapabilities columnCapabilities);
Review Comment:
I think i was just matching the vector engine version, where all of them
accept a capabilities and i find to be a nicer interface than the
non-vectorized processor factory. Capabilities is more rich than just
TypeSignature when we have access to it (and since these come from selector
factories we do), so maybe the better thing to do here is make it @Nullable,
since a null capabilities here means that the type was unknown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
