clintropolis commented on code in PR #14542:
URL: https://github.com/apache/druid/pull/14542#discussion_r1264046252
##########
processing/src/main/java/org/apache/druid/segment/VectorColumnProcessorFactory.java:
##########
@@ -83,6 +83,8 @@ T makeMultiValueDimensionProcessor(
*/
T makeLongProcessor(ColumnCapabilities capabilities, VectorValueSelector
selector);
+ T makeArrayProcessor(ColumnCapabilities capabilities, VectorObjectSelector
selector);
Review Comment:
the `ColumnProcessors` methods that call this always have
`ColumnCapabilities` though via the selector factories, and all of the other
methods have the same signature. Given that `ColumnCapabilities` is more rich
than `TypeSignature` I think its nicer to leave it as is. For the vector
engine, null `ColumnCapabilities` means a column didn't exist in the segment.
For now at least I want to be consistent instead of changing the signature, and
a number of the other make..processor methods are using stuff that only exists
on the capabilities such as checking for multi-value strings, checking
capabilities.hasNulls to know if they should check isNull on the selectors, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
