abhishekrb19 commented on code in PR #14662:
URL: https://github.com/apache/druid/pull/14662#discussion_r1275773174
##########
server/src/main/java/org/apache/druid/server/coordinator/duty/KillUnusedSegments.java:
##########
@@ -140,6 +162,12 @@ private void killUnusedSegments(Collection<String>
dataSourcesToKill)
break;
}
}
+
+ if (submittedTasks >= availableKillTaskSlots) {
+ log.info("Reached kill task slot limit with pending unused segments to
kill. Will resume "
+ + "on the next coordinator cycle.");
+ break;
+ }
}
log.debug("Submitted kill tasks for [%d] datasources.", submittedTasks);
Review Comment:
Out of scope: is this debug statement accurate? I believe it should be:
```suggestion
log.debug("Submitted [%d] kill tasks for [%d] datasources.",
submittedTasks, dataSourcesToKill.size());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
