zachjsh commented on code in PR #14662: URL: https://github.com/apache/druid/pull/14662#discussion_r1276698239
########## docs/configuration/index.md: ########## @@ -955,6 +956,7 @@ Issuing a GET request at the same URL will return the spec that is currently in |`replicationThrottleLimit`|The maximum number of segment replicas that can be assigned to a historical tier in a single Coordinator run. This property prevents historicals from becoming overwhelmed when loading extra replicas of segments that are already available in the cluster.|500| |`balancerComputeThreads`|Thread pool size for computing moving cost of segments during segment balancing. Consider increasing this if you have a lot of segments and moving segments begins to stall.|1| |`killDataSourceWhitelist`|List of specific data sources for which kill tasks are sent if property `druid.coordinator.kill.on` is true. This can be a list of comma-separated data source names or a JSON array.|none| +|`killTaskSlotRatio`| Ratio of total available task slots, including autoscaling if applicable that will be allowed for kill tasks. This limit only applies for kill tasks that are spawned automatically by the coordinator's auto kill duty, which is enabled when `druid.coordinator.kill.on` is true.| none - no limit | Review Comment: I considered this as well 😆 . I thought since other kill properties are already here at this level to expand and add more. I frankly didnt want to have to deal with the resolution of properties from multiple possible configs, deprecated and new, so decided against it. If you feel strongly let me know. And lets see what others thing as well. ########## docs/configuration/index.md: ########## @@ -955,6 +956,7 @@ Issuing a GET request at the same URL will return the spec that is currently in |`replicationThrottleLimit`|The maximum number of segment replicas that can be assigned to a historical tier in a single Coordinator run. This property prevents historicals from becoming overwhelmed when loading extra replicas of segments that are already available in the cluster.|500| |`balancerComputeThreads`|Thread pool size for computing moving cost of segments during segment balancing. Consider increasing this if you have a lot of segments and moving segments begins to stall.|1| |`killDataSourceWhitelist`|List of specific data sources for which kill tasks are sent if property `druid.coordinator.kill.on` is true. This can be a list of comma-separated data source names or a JSON array.|none| +|`killTaskSlotRatio`| Ratio of total available task slots, including autoscaling if applicable that will be allowed for kill tasks. This limit only applies for kill tasks that are spawned automatically by the coordinator's auto kill duty, which is enabled when `druid.coordinator.kill.on` is true.| none - no limit | Review Comment: I considered this as well 😆 . I thought since other kill properties are already here at this level to expand and add more. I frankly didnt want to have to deal with the resolution of properties from multiple possible configs, deprecated and new, so decided against it. If you feel strongly let me know. And lets see what others thing as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
