jon-wei commented on code in PR #14662:
URL: https://github.com/apache/druid/pull/14662#discussion_r1276916670


##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java:
##########
@@ -128,6 +146,9 @@ public TaskStatus runTask(TaskToolbox toolbox) throws 
Exception
     }
 
     // Kill segments
+    unusedSegments = maxSegmentsToKill == null
+        ? unusedSegments

Review Comment:
   I think the comment was referring to something different, about adjusting 
`RetrieveUnusedSegmentsAction(getDataSource(), getInterval()))` so that it can 
accept a limit and return a smaller set of unused segments



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to