zachjsh commented on code in PR #14662:
URL: https://github.com/apache/druid/pull/14662#discussion_r1276696551
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java:
##########
@@ -128,6 +146,9 @@ public TaskStatus runTask(TaskToolbox toolbox) throws
Exception
}
// Kill segments
+ unusedSegments = maxSegmentsToKill == null
+ ? unusedSegments
Review Comment:
I thought it was best to mark all segements in interval specified as unused.
Seemed less expensive than actually deleting the segment from deep storage, and
other things involved in killing the segment. I did consider this though. But
with the limit also applied to marking unused, a user might need multiple
requests to mark segments in interval as unused, where as if the limit is only
applied to kill, then all segments in interval are marked unused, and if we hit
limit on kill, auto kill will clean up eventually, if enabled. Let me know what
you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
