georgew5656 commented on code in PR #14887:
URL: https://github.com/apache/druid/pull/14887#discussion_r1303311446
##########
services/src/main/java/org/apache/druid/cli/CliPeon.java:
##########
@@ -282,9 +290,15 @@ public Supplier<Map<String, Object>>
heartbeatDimensions(Task task)
@Provides
@LazySingleton
- public Task readTask(@Json ObjectMapper mapper,
ExecutorLifecycleConfig config)
+ public Task readTask(@Json ObjectMapper mapper, @Smile ObjectMapper
smileMapper, ExecutorLifecycleConfig config, TaskPayloadManager
taskPayloadManager, TaskConfig taskConfig)
Review Comment:
we use the smile mapper to serialize the payload so i figured we should use
the same one to deserialize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
