georgew5656 commented on code in PR #14887:
URL: https://github.com/apache/druid/pull/14887#discussion_r1307811855
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunnerConfig.java:
##########
@@ -403,6 +419,12 @@ public Builder withCapacity(@Min(0)
@Max(Integer.MAX_VALUE) Integer capacity)
return this;
}
+ public Builder withTaskPayloadAsEnvVariable(Boolean
taskPayloadAsEnvVariable)
Review Comment:
this is called in the tests. we can't separate them because they are doing
different things. taskPayloadAsEnvVariable is enabling/disabling the TASK_JSON
env variable, and the other one is enabling/disabling managing the payload via
deep storage. If we make these one config then there is the issue of
migration/backwards compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
