georgew5656 commented on code in PR #14887: URL: https://github.com/apache/druid/pull/14887#discussion_r1303314485
########## extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/taskadapter/TaskAdapter.java: ########## @@ -31,4 +32,5 @@ public interface TaskAdapter Task toTask(Job from) throws IOException; + K8sTaskId getTaskId(Job from) throws IOException; Review Comment: i didn't want to do this because the implementation depends on logic in fromTask, since both adapters happen to add the same annotation for taskId the implementation for getTaskId is the same but this isn't necessarily the case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
