georgew5656 commented on PR #14887: URL: https://github.com/apache/druid/pull/14887#issuecomment-1690328968
> @georgew5656 The current approach also SGTM but I would not have it behind a feature flag. If you want to have a feature flag, I would optionally turn it on by default . This also means we implement that TaskPayloadManager for other deep storage mainly 'GCS,AZURE,HDFS`. If the implementation is not found, we should through a nice error message instructing the user to set `druid.indexer.runner.taskPayloadAsEnvVariable` to true or if we are not using a flag, instructing the user to implement the methods to implement 'TaskPayloadManager` for there custom deep storage impl. i didn't really want to break anyone who didn't want to use deep storage for task payloads for whatever reason. i think maybe later on if this gets used in production a bit more and the performance is okay maybe we could consider flipping it on as a default -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
