YongGang commented on code in PR #14887:
URL: https://github.com/apache/druid/pull/14887#discussion_r1307805224
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunnerConfig.java:
##########
@@ -403,6 +419,12 @@ public Builder withCapacity(@Min(0)
@Max(Integer.MAX_VALUE) Integer capacity)
return this;
}
+ public Builder withTaskPayloadAsEnvVariable(Boolean
taskPayloadAsEnvVariable)
Review Comment:
I don't see where this method is called.
And also could we consolidate the two new config items to one? The current
two configs are excluding each other thus can be misconfigured. Maybe like this:
| Config Name | Type | Description | Default | Required |
|-------------|------|-------------|---------|----------|
| `druid.indexer.task.taskPayloadHandlingMethod` | `String` | Determines how
task payloads should be passed to K8s jobs. Use `ENV_VARIABLE` if you want task
payloads to be passed as a compressed environment variable (suitable for
payloads <= 1 MB). Use `PAYLOAD_MANAGER` if you plan on using task payloads > 1
MB. | `ENV_VARIABLE` | No |
##########
docs/development/extensions-contrib/k8s-jobs.md:
##########
@@ -216,23 +216,25 @@ data:
```
### Properties
-|Property| Possible Values | Description
|Default|required|
-|--------|-----------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-------|--------|
-|`druid.indexer.runner.debugJobs`| `boolean` | Clean up K8s jobs after
tasks complete.
|False|No|
-|`druid.indexer.runner.sidecarSupport`| `boolean` | Deprecated, specify
adapter type as runtime property `druid.indexer.runner.k8s.adapter.type:
overlordMultiContainer` instead. If your overlord pod has sidecars, this will
attempt to start the task with the same sidecars as the overlord pod. |False|No|
-|`druid.indexer.runner.primaryContainerName`| `String` | If running
with sidecars, the `primaryContainerName` should be that of your druid
container like `druid-overlord`.
|First container in `podSpec` list|No|
-|`druid.indexer.runner.kubexitImage`| `String` | Used kubexit project
to help shutdown sidecars when the main pod completes. Otherwise jobs with
sidecars never terminate.
|karlkfi/kubexit:latest|No|
-|`druid.indexer.runner.disableClientProxy`| `boolean` | Use this if you
have a global http(s) proxy and you wish to bypass it.
|false|No|
-|`druid.indexer.runner.maxTaskDuration`| `Duration` | Max time a task is
allowed to run for before getting killed
|`PT4H`|No|
-|`druid.indexer.runner.taskCleanupDelay`| `Duration` | How long do jobs
stay around before getting reaped from K8s
|`P2D`|No|
-|`druid.indexer.runner.taskCleanupInterval`| `Duration` | How often to
check for jobs to be reaped
|`PT10M`|No|
-|`druid.indexer.runner.K8sjobLaunchTimeout`| `Duration` | How long to
wait to launch a K8s task before marking it as failed, on a resource
constrained cluster it may take some time.
|`PT1H`|No|
-|`druid.indexer.runner.javaOptsArray`| `JsonArray` | java opts for the
task.
|`-Xmx1g`|No|
-|`druid.indexer.runner.labels`| `JsonObject` | Additional labels you want
to add to peon pod
|`{}`|No|
-|`druid.indexer.runner.annotations`| `JsonObject` | Additional annotations
you want to add to peon pod
|`{}`|No|
-|`druid.indexer.runner.peonMonitors`| `JsonArray` | Overrides
`druid.monitoring.monitors`. Use this property if you don't want to inherit
monitors from the Overlord.
|`[]`|No|
-|`druid.indexer.runner.graceTerminationPeriodSeconds`| `Long` |
Number of seconds you want to wait after a sigterm for container lifecycle
hooks to complete. Keep at a smaller value if you want tasks to hold locks for
shorter periods.
|`PT30S` (K8s default)|No|
-|`druid.indexer.runner.capacity`| `Integer` | Number of concurrent jobs
that can be sent to Kubernetes.
|`2147483647`|No|
+|Property| Possible Values | Description
| Default |required|
Review Comment:
As I have been told the doc shouldn't be reformatted by the IDE (you can
uncheck the `Reformat table when typing` option).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
