clintropolis commented on PR #15058: URL: https://github.com/apache/druid/pull/15058#issuecomment-1752395538
>The main change LGTM (other than the one notice), but in thinking about migrations, it occurs to me that people may have been accustomed to the old behavior of these filters, and would want a way to restore it without it being linked to druid.expressions.useStrictBooleans and druid.generic.useDefaultValueForNull. (Linking means people have no way to be, like, "I want Druid 27 behavior" once Druid 28 comes out.) I think that means we end up with a third parameter. Added `druid.generic.useThreeValueLogic` as the 3rd parameter and updated docs to try to accurately describe the situation. All three of of these must be set for 3-value native filter logic (and all are by default), `druid.generic.useDefaultValueForNull=false`, `druid.generic.useThreeValueLogic=true`, and `druid.expressions.useStrictBooleans=true`. I don't love it, but hopefully someday all of these can just go away and we only have "sql compatible Druid" and no other choice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
