clintropolis commented on PR #15058: URL: https://github.com/apache/druid/pull/15058#issuecomment-1750306276
>I think the includeUnknown and isNullInputUnknown could be better named for parity. E.g. argument - includeUnknown function name - doesNotIncludeUnknown() i feel like `doesNotIncludeUnknown` doesn't really quite clearly convey the purpose of the method, which is "if `includeUnknown` is set, can we skip evaluating the predicate and just automatically return a match, or do we need to evaluate the predicate to determine if we match nulls." >or >argument - matchesUnknown function name - doesNotMatchUnknown() I went with `includeUnknown` to have a consistently named argument across all 3 interfaces that could be understandable in all 3 contexts; something like `matchesUnknown` seems sensible for value matchers but in the case of building indexes there isn't any existing match terminology in use, and so usually this parameter means 'include the null value bitmap'. idk, naming is hard, hopefully the javadocs make it clear enough the intent of these arguments and functions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
