clintropolis commented on code in PR #15058:
URL: https://github.com/apache/druid/pull/15058#discussion_r1346766167
##########
processing/src/main/java/org/apache/druid/segment/filter/ValueMatchers.java:
##########
@@ -315,6 +339,125 @@ public void inspectRuntimeShape(RuntimeShapeInspector
inspector)
};
}
+ public static ValueMatcher makeAlwaysFalseMatcher(final DimensionSelector
selector, boolean multiValue)
Review Comment:
added javadocs and also to the constant allFalse/allTrue/allUnknown methods
##########
processing/src/main/java/org/apache/druid/query/filter/DruidPredicateFactory.java:
##########
@@ -58,4 +58,9 @@ default Predicate<Object> makeObjectPredicate()
final Predicate<String> stringPredicate = makeStringPredicate();
return o -> stringPredicate.apply(null);
}
+
+ default boolean isNullInputUnknown()
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
