clintropolis commented on code in PR #15058:
URL: https://github.com/apache/druid/pull/15058#discussion_r1348467452
##########
processing/src/main/java/org/apache/druid/segment/ConstantMultiValueDimensionSelector.java:
##########
@@ -38,6 +40,10 @@ public class ConstantMultiValueDimensionSelector implements
HistoricalDimensionS
public ConstantMultiValueDimensionSelector(List<String> values)
{
+ if (CollectionUtils.isNullOrEmpty(values)) {
+ throw new IllegalArgumentException("Use
DimensionSelector.constant(null)");
Review Comment:
ah yeah, updated this when i was adjacent to some code that was still
throwing old exceptions, i can change if i push more commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
