xvrl commented on code in PR #15141:
URL: https://github.com/apache/druid/pull/15141#discussion_r1357442276
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamSequenceNumbers.java:
##########
@@ -32,7 +32,7 @@
@Type(name = "start", value = SeekableStreamStartSequenceNumbers.class),
@Type(name = "end", value = SeekableStreamEndSequenceNumbers.class)
})
-public interface SeekableStreamSequenceNumbers<PartitionIdType,
SequenceOffsetType>
+public interface SeekableStreamSequenceNumbers<PartitionIdType,
SequenceOffsetType> extends
Comparable<SeekableStreamSequenceNumbers<PartitionIdType, SequenceOffsetType>>
Review Comment:
can we add some Javadocs to explain what Comparable means in this context
and how it applies to sequence offsets?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
