xvrl commented on code in PR #15141:
URL: https://github.com/apache/druid/pull/15141#discussion_r1357444512
##########
extensions-contrib/materialized-view-maintenance/src/main/java/org/apache/druid/indexing/materializedview/DerivativeDataSourceMetadata.java:
##########
@@ -85,6 +85,12 @@ public boolean matches(DataSourceMetadata other)
return equals(other);
}
+ @Override
+ public int compareTo(DataSourceMetadata o)
+ {
+ return -1;
Review Comment:
always returning `-1` wouldn't satisfy the Comparable contract here. it
would mean A < B and B < A for any two objects A and B implementing this
interface. We might need to explain better what the contract implies or throw
an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
