xvrl commented on code in PR #15141:
URL: https://github.com/apache/druid/pull/15141#discussion_r1357443126
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamDataSourceMetadata.java:
##########
@@ -59,6 +59,18 @@ public boolean matches(DataSourceMetadata other)
return plus(other).equals(other.plus(this));
}
+ @Override
+ public int compareTo(DataSourceMetadata other)
+ {
+ if (!getClass().equals(other.getClass())) {
+ return -1;
+ }
Review Comment:
this seems inconsistent with other implementations where we throw an
exception when we encounter a different class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
