github-code-scanning[bot] commented on code in PR #15141:
URL: https://github.com/apache/druid/pull/15141#discussion_r1356679692
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamEndSequenceNumbers.java:
##########
@@ -147,6 +148,40 @@
}
}
+ @Override
+ public int compareTo(SeekableStreamSequenceNumbers<PartitionIdType,
SequenceOffsetType> other)
+ {
+ if (this.getClass() != other.getClass()) {
+ throw new IAE(
+ "Expected instance of %s, got %s",
+ this.getClass().getName(),
+ other.getClass().getName()
+ );
+ }
+
+ final SeekableStreamEndSequenceNumbers<PartitionIdType,
SequenceOffsetType> otherStart =
+ (SeekableStreamEndSequenceNumbers<PartitionIdType,
SequenceOffsetType>) other;
+
+ if (stream.equals(otherStart.stream)) {
+ //Same stream, compare the offset
+ AtomicReference<Boolean> res = new AtomicReference<>(false);
+ partitionSequenceNumberMap.forEach(
+ (partitionId, sequenceOffset) -> {
+ if (otherStart.partitionSequenceNumberMap.get(partitionId) != null
&& Long.parseLong(String.valueOf(sequenceOffset)) >
Long.parseLong(String.valueOf(otherStart.partitionSequenceNumberMap.get(partitionId))))
{
Review Comment:
## Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5895)
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamStartSequenceNumbers.java:
##########
@@ -161,6 +162,40 @@
}
}
+ @Override
+ public int compareTo(SeekableStreamSequenceNumbers<PartitionIdType,
SequenceOffsetType> other)
+ {
+ if (this.getClass() != other.getClass()) {
+ throw new IAE(
+ "Expected instance of %s, got %s",
+ this.getClass().getName(),
+ other.getClass().getName()
+ );
+ }
+
+ final SeekableStreamStartSequenceNumbers<PartitionIdType,
SequenceOffsetType> otherStart =
+ (SeekableStreamStartSequenceNumbers<PartitionIdType,
SequenceOffsetType>) other;
+
+ if (stream.equals(otherStart.stream)) {
+ //Same stream, compare the offset
+ AtomicReference<Boolean> res = new AtomicReference<>(false);
+ partitionSequenceNumberMap.forEach(
+ (partitionId, sequenceOffset) -> {
+ if (otherStart.partitionSequenceNumberMap.get(partitionId) != null
&& Long.parseLong(String.valueOf(sequenceOffset)) >
Long.parseLong(String.valueOf(otherStart.partitionSequenceNumberMap.get(partitionId))))
{
Review Comment:
## Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5898)
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamStartSequenceNumbers.java:
##########
@@ -161,6 +162,40 @@
}
}
+ @Override
+ public int compareTo(SeekableStreamSequenceNumbers<PartitionIdType,
SequenceOffsetType> other)
+ {
+ if (this.getClass() != other.getClass()) {
+ throw new IAE(
+ "Expected instance of %s, got %s",
+ this.getClass().getName(),
+ other.getClass().getName()
+ );
+ }
+
+ final SeekableStreamStartSequenceNumbers<PartitionIdType,
SequenceOffsetType> otherStart =
+ (SeekableStreamStartSequenceNumbers<PartitionIdType,
SequenceOffsetType>) other;
+
+ if (stream.equals(otherStart.stream)) {
+ //Same stream, compare the offset
+ AtomicReference<Boolean> res = new AtomicReference<>(false);
+ partitionSequenceNumberMap.forEach(
+ (partitionId, sequenceOffset) -> {
+ if (otherStart.partitionSequenceNumberMap.get(partitionId) != null
&& Long.parseLong(String.valueOf(sequenceOffset)) >
Long.parseLong(String.valueOf(otherStart.partitionSequenceNumberMap.get(partitionId))))
{
Review Comment:
## Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5897)
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamEndSequenceNumbers.java:
##########
@@ -147,6 +148,40 @@
}
}
+ @Override
+ public int compareTo(SeekableStreamSequenceNumbers<PartitionIdType,
SequenceOffsetType> other)
+ {
+ if (this.getClass() != other.getClass()) {
+ throw new IAE(
+ "Expected instance of %s, got %s",
+ this.getClass().getName(),
+ other.getClass().getName()
+ );
+ }
+
+ final SeekableStreamEndSequenceNumbers<PartitionIdType,
SequenceOffsetType> otherStart =
+ (SeekableStreamEndSequenceNumbers<PartitionIdType,
SequenceOffsetType>) other;
+
+ if (stream.equals(otherStart.stream)) {
+ //Same stream, compare the offset
+ AtomicReference<Boolean> res = new AtomicReference<>(false);
+ partitionSequenceNumberMap.forEach(
+ (partitionId, sequenceOffset) -> {
+ if (otherStart.partitionSequenceNumberMap.get(partitionId) != null
&& Long.parseLong(String.valueOf(sequenceOffset)) >
Long.parseLong(String.valueOf(otherStart.partitionSequenceNumberMap.get(partitionId))))
{
Review Comment:
## Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5896)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
