kfaraz commented on code in PR #16328:
URL: https://github.com/apache/druid/pull/16328#discussion_r1579156512
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/Task.java:
##########
@@ -331,4 +333,10 @@ static TaskInfo<TaskIdentifier, TaskStatus>
toTaskIdentifierInfo(TaskInfo<Task,
taskInfo.getTask().getMetadata()
);
}
+
+ @Nullable
+ default List<String> getLookupsToLoad()
Review Comment:
We can use a wrapper as suggested here
https://github.com/apache/druid/pull/16328#issuecomment-2075054859
> We have attached a special meaning to `null`. In other words, `null` here
means `Load Everything`, which is not too great. This can always be remedied
though by returning a wrapper object instead of just a `List<String>`. The
wrapper object can have a boolean or enum flag to indicate the tristate: `ALL,
NONE, REQUIRED`.
But I am not sure I follow why it would be difficult to pass a nullable
parameter via context (especially since null is the default we want).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
