IgorBerman commented on code in PR #16328:
URL: https://github.com/apache/druid/pull/16328#discussion_r1580511273
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java:
##########
@@ -1523,4 +1523,10 @@ public CompactionTuningConfig
withPartitionsSpec(PartitionsSpec partitionsSpec)
);
}
}
+
+ @Override
+ public List<String> getLookupsToLoad()
+ {
+ return Collections.emptyList();
Review Comment:
I assumed compactions are not using lookups since they load already stored
data and save it as is in bigger files or with some rollup. I don't see how to
apply aggregation function in documentation of compaction task
https://druid.apache.org/docs/latest/data-management/manual-compaction#compaction-transform-spec,
but there might be some case which I'm not aware of.
Anyway, your next PR will permit to configure lookups used per task in
config as per my understanding, so I would be able to disable loading lookups
for our specific case (simple rollups)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
