Akshat-Jain commented on code in PR #16328:
URL: https://github.com/apache/druid/pull/16328#discussion_r1579186914
##########
services/src/main/java/org/apache/druid/cli/CliPeon.java:
##########
@@ -356,6 +356,14 @@ public String getTaskIDFromTask(final Task task)
{
return task.getId();
}
+
+ @Provides
+ @LazySingleton
+ @Named(DataSourceTaskIdHolder.LOOKUPS_TO_LOAD_FOR_TASK)
+ public List<String> getLookupsToLoad(final Task task)
Review Comment:
I tried using Indexers. All lookups are loaded at the very beginning for
Indexers. Changes of this PR don't affect the Indexer flow in any way.
For MM-less system, I'm not sure yet. @cryptoe Based on our earlier
discussion, I have to setup the Kubernetes thing locally and try MM-less
ingestion, and see what happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
