Akshat-Jain commented on code in PR #16328:
URL: https://github.com/apache/druid/pull/16328#discussion_r1579196223
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/Task.java:
##########
@@ -331,4 +333,10 @@ static TaskInfo<TaskIdentifier, TaskStatus>
toTaskIdentifierInfo(TaskInfo<Task,
taskInfo.getTask().getMetadata()
);
}
+
+ @Nullable
+ default List<String> getLookupsToLoad()
Review Comment:
> Keys with null will be difficult to pass via context. Can we use a pojo
instead here ?
@cryptoe I'm not entirely sure I follow. I was thinking of passing another
key-value pair in `context` which IIUC is an existing task param.
```
context: {
// existing fields,
"lookupsToLoad": ["name1", "name2"] // or null
}
```
And the `getLookupsToLoad()` method can parse `context["lookupsToLoad"]` and
handle null cases properly. It can also return null if `context` doesn't have
`lookupsToLoad` key.
I don't have the end-to-end implementation ready, but this is what I had in
my mind currently. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
