Akshat-Jain commented on code in PR #16328:
URL: https://github.com/apache/druid/pull/16328#discussion_r1579189701
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java:
##########
@@ -1523,4 +1523,10 @@ public CompactionTuningConfig
withPartitionsSpec(PartitionsSpec partitionsSpec)
);
}
}
+
+ @Override
+ public List<String> getLookupsToLoad()
+ {
+ return Collections.emptyList();
Review Comment:
I'm lacking context regarding compaction task. The other PR disabled loading
lookups for compaction tasks. The original issue
(https://github.com/apache/druid/issues/13324#issue-1439073000) also states
that task types such as compaction have no use of lookups.
@cryptoe Who would be the right person to confirm this?
cc: @kfaraz @IgorBerman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
