YongGang commented on code in PR #16510:
URL: https://github.com/apache/druid/pull/16510#discussion_r1631704583
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/KubernetesPeonClient.java:
##########
@@ -270,10 +270,16 @@ Pod getPeonPodWithRetries(KubernetesClient client, String
jobName, int quietTrie
}
}
- private void emitK8sPodMetrics(Task task, String metric, long durationMs)
+ private void emitK8sPodMetrics(Task task, Job job, String metric, long
durationMs)
{
ServiceMetricEvent.Builder metricBuilder = new
ServiceMetricEvent.Builder();
IndexTaskUtils.setTaskDimensions(metricBuilder, task);
+ if (job.getMetadata() != null && job.getMetadata().getAnnotations() !=
null) {
+ metricBuilder.setDimensionIfNotNull(
+ "podTemplate",
+
job.getMetadata().getAnnotations().get(DruidK8sConstants.POD_TEMPLATE_KEY)
+ );
+ }
Review Comment:
It's for metrics reporting, but don't think we need that anymore, will
revert this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
