YongGang commented on PR #16510:
URL: https://github.com/apache/druid/pull/16510#issuecomment-2155634728
Thanks @suneet-s for your comments:
> The Selector contains a selection key and implicit matching conditions.
These matching conditions are specific to a usecase, but it is not clear why
these specific fields are chosen.
If we rename `Selector` to `TaskPropertiesSelector` should address this
concern?
For this following suggestion:
```
{
"selectionKey": "someKey",
"matcher": {
"type": "myCustomMatcher",
"context.tags": {..},
"task": {...}
}
}
```
are we actually suggesting to do this?:
```
{
"selectionKey": "someKey",
"matchers": [
{
"type": "dataSource",
"matchingNames": ["ds0"]
},
{
"type": "context",
"field": "myContextKey"
"matchingNames": ["anyValue"]
},
]
}
```
Otherwise if we still have a single `matcher` within a `selector`, I'm not
sure about the benefit of introducing another layer of Jackson object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
