YongGang commented on code in PR #16510: URL: https://github.com/apache/druid/pull/16510#discussion_r1631700389
########## extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/execution/DynamicTaskPodTemplateSelectStrategy.java: ########## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.k8s.overlord.execution; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; +import io.fabric8.kubernetes.api.model.PodTemplate; +import org.apache.druid.indexing.common.task.Task; +import org.apache.druid.java.util.common.Pair; + +import java.util.List; +import java.util.Map; +import java.util.Objects; + +/** + * Implements {@link PodTemplateSelectStrategy} by dynamically evaluating a series of selectors. + * Each selector corresponds to a potential task template key. + */ +public class DynamicTaskPodTemplateSelectStrategy implements PodTemplateSelectStrategy +{ + private List<Selector> templateSelectors; + + @JsonCreator + public DynamicTaskPodTemplateSelectStrategy( + @JsonProperty("templateSelectors") List<Selector> templateSelectors + ) + { + this.templateSelectors = templateSelectors; + } + + /** + * Evaluates the provided task against the set selectors to determine its template. + * + * @param task the task to be checked + * @return the template if a selector matches, otherwise fallback to base template + */ + @Override + public Pair<String, PodTemplate> getPodTemplateForTask(Task task, Map<String, PodTemplate> templates) + { + String templateKey; + if (templateSelectors == null) { + templateKey = null; + } else { + templateKey = templateSelectors.stream() + .filter(selector -> selector.evaluate(task)) + .findFirst() + .map(Selector::getSelectionKey) + .orElse(null); Review Comment: The fallback to base template is implemented in `PodTemplateSelectStrategy` interface, so no need to have this logic in each strategy implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
