YongGang commented on code in PR #16510:
URL: https://github.com/apache/druid/pull/16510#discussion_r1633693215
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesOverlordModule.java:
##########
@@ -75,6 +79,7 @@ public void configure(Binder binder)
JsonConfigProvider.bind(binder,
IndexingServiceModuleHelper.INDEXER_RUNNER_PROPERTY_PREFIX,
KubernetesTaskRunnerConfig.class);
JsonConfigProvider.bind(binder, K8SANDWORKER_PROPERTIES_PREFIX,
KubernetesAndWorkerTaskRunnerConfig.class);
JsonConfigProvider.bind(binder, "druid.indexer.queue",
TaskQueueConfig.class);
+ JacksonConfigProvider.bind(binder,
KubernetesTaskRunnerDynamicConfig.CONFIG_KEY,
KubernetesTaskRunnerDynamicConfig.class, null);
Review Comment:
As the binding is to a record from database, the record can be updated or
deleted at runtime, thus we still need to do some null checkings to be safe.
It's also similar to how `WorkerBehaviorConfig` is used now and the the null
checking is only in one place, so it's quite clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
