cryptoe commented on code in PR #16864:
URL: https://github.com/apache/druid/pull/16864#discussion_r1709310688
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQCompactionRunner.java:
##########
@@ -237,7 +238,11 @@ private static DataSourceMSQDestination
buildMSQDestination(
dataSchema.getDataSource(),
dataSchema.getGranularitySpec().getSegmentGranularity(),
null,
- ImmutableList.of(replaceInterval)
+ ImmutableList.of(replaceInterval),
+ dataSchema.getDimensionsSpec()
Review Comment:
What about cases where dimension schema is not present in the compaction
spec, would those dimensions be present in this schema ?
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQSpec.java:
##########
@@ -43,7 +43,7 @@ public class MSQSpec
@JsonCreator
public MSQSpec(
@JsonProperty("query") Query<?> query,
- @JsonProperty("columnMappings") @Nullable ColumnMappings columnMappings,
+ @JsonProperty("columnMappings") ColumnMappings columnMappings,
Review Comment:
Is there a reason null-able is removed ?
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -2236,7 +2253,8 @@ private static Pair<List<DimensionSchema>,
List<AggregatorFactory>> makeDimensio
outputColumnAggregatorFactories,
outputColumnName,
type,
- query.context()
+ query.context(),
+ dimensionToSchemaMap
Review Comment:
Where are they getting piped to the segment generator factory ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
