clintropolis commented on code in PR #16533:
URL: https://github.com/apache/druid/pull/16533#discussion_r1715828772
##########
processing/src/main/java/org/apache/druid/segment/FilteredStorageAdapter.java:
##########
@@ -45,26 +42,21 @@ public FilteredStorageAdapter(final StorageAdapter adapter,
final DimFilter filt
}
@Override
- public Sequence<Cursor> makeCursors(
- @Nullable Filter filter,
- Interval interval,
- VirtualColumns virtualColumns,
- Granularity gran,
- boolean descending,
- @Nullable QueryMetrics<?> queryMetrics
- )
+ public CursorHolder makeCursorHolder(CursorBuildSpec spec)
{
- final Filter andFilter;
- if (filter == null) {
+ final CursorBuildSpec.CursorBuildSpecBuilder buildSpecBuilder =
CursorBuildSpec.builder(spec);
+ final Filter newFilter;
+ if (spec.getFilter() == null) {
if (filterOnDataSource != null) {
Review Comment:
`FilteredDataSource` allows null for some reason, so i just marked it
nullable and added a check for now. I don't really understand why we would
allow filter to be null though, that doesn't seem very useful, so it might be
worth looking into changing it to ensure not null in a follow-up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
