clintropolis commented on code in PR #16533:
URL: https://github.com/apache/druid/pull/16533#discussion_r1715835436
##########
processing/src/main/java/org/apache/druid/segment/join/HashJoinEngine.java:
##########
@@ -250,12 +244,32 @@ public boolean isDoneOrInterrupted()
return isDone() || Thread.currentThread().isInterrupted();
}
+ @Override
+ public void mark()
+ {
+ joinMarkId = joinColumnSelectorFactory.getRowId();
+ }
+
+ @Override
+ public void resetToMark()
+ {
+ leftCursor.reset();
+ joinMatcher.reset();
+ joinColumnSelectorFactory.resetRowId();
+ initialize();
+ while (!isDone() && joinColumnSelectorFactory.getRowId() < joinMarkId)
{
Review Comment:
discussed offline but to update here, for now have decided to update these
and loosen the contract so that mark/resetToMark only guarantee return to same
timestamp since that is all topN needs, and also since stuff like lookup
segments could change on iterating again, and added some tests about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
