clintropolis commented on code in PR #16533: URL: https://github.com/apache/druid/pull/16533#discussion_r1710297048
########## processing/src/main/java/org/apache/druid/segment/CursorBuildSpec.java: ########## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.segment; + +import com.google.common.collect.ImmutableList; +import com.google.common.collect.Iterables; +import org.apache.druid.java.util.common.Intervals; +import org.apache.druid.java.util.common.granularity.Granularities; +import org.apache.druid.java.util.common.granularity.Granularity; +import org.apache.druid.query.QueryContext; +import org.apache.druid.query.QueryMetrics; +import org.apache.druid.query.aggregation.AggregatorFactory; +import org.apache.druid.query.filter.Filter; +import org.apache.druid.query.scan.Order; +import org.apache.druid.query.scan.OrderBy; +import org.apache.druid.segment.column.ColumnHolder; +import org.joda.time.Interval; + +import javax.annotation.Nullable; +import java.util.Arrays; +import java.util.Collections; +import java.util.List; + +public class CursorBuildSpec +{ + public static final CursorBuildSpec FULL_SCAN = CursorBuildSpec.builder().build(); + + public static CursorBuildSpecBuilder builder() + { + return new CursorBuildSpecBuilder(); + } + + public static CursorBuildSpecBuilder builder(CursorBuildSpec spec) + { + return new CursorBuildSpecBuilder(spec); + } + + @Nullable + private final Filter filter; + private final Interval interval; + @Nullable + private final List<String> groupingColumns; + private final VirtualColumns virtualColumns; + @Nullable + private final List<AggregatorFactory> aggregators; + @Nullable + private final List<OrderBy> orderByColumns; + + private final QueryContext queryContext; + + @Nullable + private final QueryMetrics<?> queryMetrics; + + public CursorBuildSpec( + @Nullable Filter filter, + Interval interval, + @Nullable List<String> groupingColumns, + VirtualColumns virtualColumns, + @Nullable List<AggregatorFactory> aggregators, + @Nullable List<OrderBy> preferredOrdering, + QueryContext queryContext, + @Nullable QueryMetrics<?> queryMetrics + ) + { + this.filter = filter; + this.interval = interval; + this.groupingColumns = groupingColumns; + this.virtualColumns = virtualColumns; + this.aggregators = aggregators; + this.orderByColumns = preferredOrdering; + this.queryContext = queryContext; + this.queryMetrics = queryMetrics; + } + + @Nullable + public Filter getFilter() + { + return filter; + } + + public Interval getInterval() + { + return interval; + } + + @Nullable + public List<String> getGroupingColumns() + { + return groupingColumns; + } + + public VirtualColumns getVirtualColumns() + { + return virtualColumns; + } + + @Nullable + public List<AggregatorFactory> getAggregators() + { + return aggregators; + } + + @Nullable + public List<OrderBy> getPreferredOrdering() + { + return orderByColumns; + } + + public QueryContext getQueryContext() + { + return queryContext; + } + + @Nullable + public QueryMetrics<?> getQueryMetrics() + { + return queryMetrics; + } + + public static boolean preferDescendingTimeOrder(@Nullable List<OrderBy> preferredOrdering) + { + if (preferredOrdering != null && preferredOrdering.size() == 1) { + final OrderBy orderBy = Iterables.getOnlyElement(preferredOrdering); + return ColumnHolder.TIME_COLUMN_NAME.equals(orderBy.getColumnName()) && Order.DESCENDING == orderBy.getOrder(); + } + return false; + } + + public static class CursorBuildSpecBuilder + { + @Nullable + private Filter filter; + private Interval interval = Intervals.ETERNITY; + + @Nullable + private List<String> groupingColumns; + private VirtualColumns virtualColumns = VirtualColumns.EMPTY; + @Nullable + private List<AggregatorFactory> aggregators; + @Nullable + private List<OrderBy> preferredOrdering; + + private QueryContext queryContext = QueryContext.empty(); + @Nullable + private QueryMetrics<?> queryMetrics; + + private CursorBuildSpecBuilder() + { + // initialize with defaults + } + + private CursorBuildSpecBuilder(CursorBuildSpec buildSpec) + { + this.filter = buildSpec.filter; + this.interval = buildSpec.interval; + this.groupingColumns = buildSpec.groupingColumns; + this.virtualColumns = buildSpec.virtualColumns; + this.aggregators = buildSpec.aggregators; + this.preferredOrdering = buildSpec.orderByColumns; + this.queryContext = buildSpec.queryContext; + this.queryMetrics = buildSpec.queryMetrics; + } + + public CursorBuildSpecBuilder setFilter(@Nullable Filter filter) + { + this.filter = filter; + return this; + } + + public CursorBuildSpecBuilder setInterval(Interval interval) + { + this.interval = interval; + return this; + } + + public CursorBuildSpecBuilder setGroupingAndVirtualColumns( + Granularity granularity, + @Nullable List<String> groupingColumns, + VirtualColumns virtualColumns + ) + { + final VirtualColumn granularityVirtual = Granularities.toVirtualColumn(granularity); Review Comment: yea, i guess doing the query -> buildspec translation in the engines would make more sense which i think also would satisfy many of your complaints, will move it there. as for the other thing, maybe we should make a specialized time floor virtual column to use instead of expression version, will think about it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
