gianm commented on code in PR #16533:
URL: https://github.com/apache/druid/pull/16533#discussion_r1710310631
##########
processing/src/main/java/org/apache/druid/segment/CursorFactory.java:
##########
@@ -32,35 +33,59 @@
* Interface extended by {@link StorageAdapter}, which gives them the power to
create cursors.
*
* @see StorageAdapter
+ *
+ * @deprecated This interface is deprecated and no longer implemented by any
built-in {@link StorageAdapter}. Callers
+ * should use {@link CursorMakerFactory#makeCursorHolder(CursorBuildSpec)}
instead. Implementors should implement
+ * {@link CursorMakerFactory#makeCursorHolder(CursorBuildSpec)} instead.
*/
+@Deprecated
Review Comment:
Oops, I didn't mean to actually leave this comment. I changed my mind, I
think it's ok to shift to the new interface now as long as we keep certain
parts of it that may evolve (such as `setGroupingAndVirtualColumns`) marked
specifically as should-be-avoided-for-now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
