github-advanced-security[bot] commented on code in PR #16533:
URL: https://github.com/apache/druid/pull/16533#discussion_r1716255570
##########
processing/src/main/java/org/apache/druid/segment/StorageAdapter.java:
##########
@@ -21,20 +21,99 @@
import com.google.common.collect.Iterables;
import org.apache.druid.guice.annotations.PublicApi;
+import org.apache.druid.java.util.common.granularity.Granularities;
+import org.apache.druid.query.OrderBy;
import org.apache.druid.segment.column.ColumnCapabilities;
import org.apache.druid.segment.column.RowSignature;
import org.apache.druid.segment.data.Indexed;
+import org.apache.druid.segment.vector.VectorCursor;
import org.joda.time.DateTime;
import org.joda.time.Interval;
import javax.annotation.Nullable;
+import java.util.List;
import java.util.Optional;
/**
*/
@PublicApi
-public interface StorageAdapter extends CursorFactory, ColumnInspector
+public interface StorageAdapter extends CursorFactory, ColumnInspector,
CursorHolderFactory
{
+
+ /**
+ * Build a {@link CursorHolder} which can provide {@link Cursor} and {@link
VectorCursor} (if capable) which allows
+ * scanning segments and creating {@link ColumnSelectorFactory} and
+ * {@link org.apache.druid.segment.vector.VectorColumnSelectorFactory}
respectively to read row values at the cursor
+ * position.
+ */
+ @Override
+ default CursorHolder makeCursorHolder(CursorBuildSpec spec)
+ {
+ // adequate for time ordering, but needs to be updated if we support
cursors ordered other time as the primary
+ final List<OrderBy> ordering;
+ final boolean descending;
+ if (Cursors.preferDescendingTimeOrdering(spec)) {
+ ordering = Cursors.descendingTimeOrder();
+ descending = true;
+ } else {
+ ordering = Cursors.ascendingTimeOrder();
+ descending = false;
+ }
+ return new CursorHolder()
+ {
+ @Override
+ public boolean canVectorize()
+ {
+ return StorageAdapter.this.canVectorize(
+ spec.getFilter(),
+ spec.getVirtualColumns(),
+ Cursors.preferDescendingTimeOrdering(spec)
+ );
Review Comment:
## Deprecated method or constructor invocation
Invoking [CursorFactory.canVectorize](1) should be avoided because it has
been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/7709)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
