suneet-s commented on code in PR #17442:
URL: https://github.com/apache/druid/pull/17442#discussion_r1827001112
##########
extensions-contrib/rabbit-stream-indexing-service/src/main/java/org/apache/druid/indexing/rabbitstream/RabbitStreamIndexTaskIOConfig.java:
##########
@@ -50,8 +50,8 @@ public RabbitStreamIndexTaskIOConfig(
@JsonProperty("consumerProperties") Map<String, Object>
consumerProperties,
@JsonProperty("pollTimeout") Long pollTimeout,
@JsonProperty("useTransaction") Boolean useTransaction,
- @JsonProperty("minimumMessageTime") DateTime minimumMessageTime,
- @JsonProperty("maximumMessageTime") DateTime maximumMessageTime,
+ @JsonProperty("lateMessageRejectionPeriod") Duration
lateMessageRejectionPeriod,
+ @JsonProperty("earlyMessageRejectionPeriod") Duration
earlyMessageRejectionPeriod,
Review Comment:
These new fields need to be in addition to the old fields to ensure a newer
version of the overlord works with older versions of the indexing tasks. But
more importantly, in the case of a rollback - an older overlord needs to work
with a newer version of indexing services
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
