adithyachakilam commented on code in PR #17442:
URL: https://github.com/apache/druid/pull/17442#discussion_r1827012102
##########
extensions-contrib/rabbit-stream-indexing-service/src/main/java/org/apache/druid/indexing/rabbitstream/RabbitStreamIndexTaskIOConfig.java:
##########
@@ -50,8 +50,8 @@ public RabbitStreamIndexTaskIOConfig(
@JsonProperty("consumerProperties") Map<String, Object>
consumerProperties,
@JsonProperty("pollTimeout") Long pollTimeout,
@JsonProperty("useTransaction") Boolean useTransaction,
- @JsonProperty("minimumMessageTime") DateTime minimumMessageTime,
- @JsonProperty("maximumMessageTime") DateTime maximumMessageTime,
+ @JsonProperty("lateMessageRejectionPeriod") Duration
lateMessageRejectionPeriod,
+ @JsonProperty("earlyMessageRejectionPeriod") Duration
earlyMessageRejectionPeriod,
Review Comment:
May to avoid all these issues, How about instead of propagating periods, Is
it okay if we just recalculate the period min/max time (and avoid introducing
these new fields)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
