adithyachakilam commented on code in PR #17442:
URL: https://github.com/apache/druid/pull/17442#discussion_r1829918957
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java:
##########
@@ -2092,4 +2109,47 @@ protected abstract void possiblyResetDataSourceMetadata(
protected abstract boolean isEndOffsetExclusive();
protected abstract TypeReference<List<SequenceMetadata<PartitionIdType,
SequenceOffsetType>>> getSequenceMetadataTypeReference();
+
+
+ private void addTaskDurationToMinMaxTimes()
+ {
+ if (minMessageTime.isPresent()) {
+ minMessageTime = Optional.of(minMessageTime.get()
Review Comment:
Yeah its ok.
Its complaining because we are using the same variable to update the value
but we only do it once every taskDuration. If it was done more frequently we
should have used atomic references.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
