adithyachakilam commented on code in PR #17442:
URL: https://github.com/apache/druid/pull/17442#discussion_r1829910832
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskIOConfig.java:
##########
@@ -51,7 +53,8 @@ public SeekableStreamIndexTaskIOConfig(
final Boolean useTransaction,
final DateTime minimumMessageTime,
final DateTime maximumMessageTime,
- @Nullable final InputFormat inputFormat
+ @Nullable final InputFormat inputFormat,
+ @Nullable final Duration taskDuration // can be null for backward
compabitility
Review Comment:
I think its good to have Duration and no need to convert back and forth and
also confusion of adding `mins` to the variable. You think there are any issues
with the schema deserializing ? (I see at least `Period` used, maybe we can
switch to it if so )
Also, regarding variable name change, Do you think there would be a usecase
of user editing it to a different value ? I would prefer to use `taskDuration`
so that no one touches and would also avoid the need for docs (Also, I dont
find this documented anywhere, can you point me to the file ?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
