vorburger commented on a change in pull request #670: FINERACT-702: Integrate
SpotBugs and fix over 300 high priority issues
URL: https://github.com/apache/fineract/pull/670#discussion_r357919269
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/api/AuthenticationApiResource.java
##########
@@ -112,12 +113,12 @@ public String authenticate(@QueryParam("username")
@ApiParam(value = "username")
principal.hasSpecificPermissionTo(TwoFactorConstants.BYPASS_TWO_FACTOR_PERMISSION);
if
(this.springSecurityPlatformSecurityContext.doesPasswordHasToBeRenewed(principal))
{
authenticatedUserData = new AuthenticatedUserData(username,
principal.getId(),
- new String(base64EncodedAuthenticationKey),
isTwoFactorRequired);
+ new String(base64EncodedAuthenticationKey,
Charset.defaultCharset()), isTwoFactorRequired);
Review comment:
use UTF-8 instead of platform default charset
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
