vorburger commented on a change in pull request #670: FINERACT-702: Integrate
SpotBugs and fix over 300 high priority issues
URL: https://github.com/apache/fineract/pull/670#discussion_r357918888
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/domain/LoanProductProvisioningEntry.java
##########
@@ -125,4 +126,9 @@ public boolean equals(Object obj) {
&& entry.office.getId().equals(this.office.getId())
&& entry.getCurrencyCode().equals(this.getCurrencyCode());
}
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(entry, criteriaId, office, currencyCode,
loanProduct, provisioningCategory, overdueInDays, reservedAmount,
liabilityAccount, expenseAccount);
Review comment:
This again looks like it does not "match" the equals() method, which, to me,
seems wrong... or am I not getting something JPA/OpenJPA (Hibernate) specific
here? (I forgot what the deal was re. equals and hashCode for `@Entity`
classes.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
