vorburger commented on a change in pull request #670: FINERACT-702: Integrate
SpotBugs and fix over 300 high priority issues
URL: https://github.com/apache/fineract/pull/670#discussion_r357920007
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/service/ChargeReadPlatformServiceImpl.java
##########
@@ -225,6 +225,7 @@ private void
processChargeExclusionsForLoans(ChargeTimeType[] excludeChargeTimes
sb.append(excludeChargeTimes[i].getValue());
}
excludeClause = excludeClause.append(" and c.charge_time_enum not
in(" + sb.toString() + ") ");
+ excludeClause.append(" ");
Review comment:
I'm guessing you had a good reason to add this, but can I ask why? Did
SpotBugs suggest this? Why?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
