vorburger commented on a change in pull request #670: FINERACT-702: Integrate SpotBugs and fix over 300 high priority issues URL: https://github.com/apache/fineract/pull/670#discussion_r357920656
########## File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/domain/LoanProductConfigurableAttributes.java ########## @@ -18,19 +18,18 @@ */ package org.apache.fineract.portfolio.loanproduct.domain; -import javax.persistence.Column; -import javax.persistence.Entity; -import javax.persistence.JoinColumn; -import javax.persistence.ManyToOne; -import javax.persistence.Table; - +import org.apache.commons.lang.builder.EqualsBuilder; Review comment: as above, why use Commons Lang here but java.lang.Objects helpers everywhere else? The Commons Lang helpers are less efficient, because they create intermediate very short live objects (to be GC'd), which can be easily avoided. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
