vorburger commented on a change in pull request #670: FINERACT-702: Integrate
SpotBugs and fix over 300 high priority issues
URL: https://github.com/apache/fineract/pull/670#discussion_r357921010
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/template/service/TemplateMergeService.java
##########
@@ -162,7 +150,7 @@ private static String getStringFromInputStream(final
InputStream is) {
String line;
try {
- br = new BufferedReader(new InputStreamReader(is));
+ br = new BufferedReader(new InputStreamReader(is,
Charset.defaultCharset()));
Review comment:
again IMHO just hard coding UTF-8 here is safer (as more stable and
reproducible) than relying on platform default encoding
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
