vorburger commented on a change in pull request #670: FINERACT-702: Integrate
SpotBugs and fix over 300 high priority issues
URL: https://github.com/apache/fineract/pull/670#discussion_r357918428
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/accounting/common/AccountingConstants.java
##########
@@ -290,13 +290,11 @@ public static FinancialActivityData
toFinancialActivityData(final int financialA
}
public static List<FinancialActivityData> getAllFinancialActivities() {
- if (financialActivities == null) {
Review comment:
Technically this changes the behaviour, agreed? Before, if it were to be
called twice, it would do the conert and add only once (the first time when it
was null), whereas as it's now it would re-add it. I don't understand enough of
the functionality here, but do you think this is a safe change? Should we be
extra careful and avoid touching this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
