chaokunyang commented on code in PR #2532:
URL: https://github.com/apache/fory/pull/2532#discussion_r2302692020
##########
ci/deploy.sh:
##########
@@ -85,6 +85,21 @@ build_pyfory() {
else
$PYTHON_CMD setup.py bdist_wheel --dist-dir="$ROOT/dist"
fi
+ elif [[ "$OSTYPE" == "msys" || "$OSTYPE" == "win32" ]]; then
+
+ if [ -n "$GITHUB_REF_NAME" ]; then
+ # Strip leading 'v' if present
+ version="${GITHUB_REF_NAME#v}"
Review Comment:
This may not generate right verson, the release.py have special handle for
version, which change `0.12.1-rc1` to `0.12.1rc1`:
```python
def _update_python_version(lines, v: str):
for index, line in enumerate(lines):
if "__version__ = " in line:
v = v.replace("-alpha", "a")
v = v.replace("-beta", "b")
v = v.replace("-rc", "rc")
lines[index] = f'__version__ = "{v}"\n'
break
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
