esafak commented on code in PR #2532:
URL: https://github.com/apache/fory/pull/2532#discussion_r2302701836
##########
ci/deploy.sh:
##########
@@ -85,6 +85,21 @@ build_pyfory() {
else
$PYTHON_CMD setup.py bdist_wheel --dist-dir="$ROOT/dist"
fi
+ elif [[ "$OSTYPE" == "msys" || "$OSTYPE" == "win32" ]]; then
+
+ if [ -n "$GITHUB_REF_NAME" ]; then
+ # Strip leading 'v' if present
+ version="${GITHUB_REF_NAME#v}"
+ echo "Using version from GITHUB_REF_NAME: $version"
+
+ # Windows tends to drop alpha/beta markers - force it through setup.cfg
Review Comment:
If you look at [the windows artifacts being uploaded
recently](https://github.com/apache/fory/actions/runs/17227356645/job/48874547955#annotation:4:142),
you'll see the version is incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
